Eligibility identifier identifies only together with the category

https://kerfors.github.io/usdm-overlay/id/finding/eligibility-identifier-needs-category

In some published examples, EligibilityCriterion.identifier restarts per category (inclusion and exclusion each start at 1) and is not repeated within a category. The identifier alone does not identify a criterion; the identifier with the category does.

standing
For discussion: Rests on the published example files, which are not mature study definitions.
evidence
Example-observed
holds
true
observation
Alexion_NCT04573309_Wilsons.json InterventionalStudyDesign_1: 31 criteria, 12 identifiers repeated, 0 repeated within a category; CDISC_Pilot_Study.json InterventionalStudyDesign_1: 31 criteria, 0 identifiers repeated, 0 repeated within a category; EliLilly_NCT03421379_Diabetes.json InterventionalStudyDesign_1: 36 criteria, 0 identifiers repeated, 0 repeated within a category; devices.json InterventionalStudyDesign_1: 4 criteria, 0 identifiers repeated, 0 repeated within a category; observational.json ObservationalStudyDesign_1: 5 criteria, 2 identifiers repeated, 0 repeated within a category.
about
EligibilityCriterion
sources
https://github.com/cdisc-org/DDF-RA/tree/v4.0.0/Documents/Examples

Test

Check function eligibility_identifier_needs_category in scripts/check_findings.py.